kriegaex commented on code in PR #854:
URL:
https://github.com/apache/maven-shade-plugin/pull/854#discussion_r4068489330
##########
src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java:
##########
@@ -191,12 +191,11 @@ private boolean removeServicesFromDir(Clazzpath cp,
Set<Clazz> neededClasses, St
continue;
}
- try (BufferedReader configFileReader =
- new BufferedReader(new InputStreamReader(new
FileInputStream(serviceProviderConfigFile), UTF_8))) {
+ try (BufferedReader configFileReader =
Files.newBufferedReader(serviceProviderConfigFile.toPath(), UTF_8)) {
// check whether the found classes use services in turn
repeatScan |= scanServiceProviderConfigFile(cp,
configFileReader);
} catch (final IOException e) {
- log.warn(e.getMessage());
+ log.warn("Failed to scan service provider config file " +
serviceProviderConfigFile, e);
Review Comment:
@rmannibucau I thought that the log channels also correspond to log levels,
i.e. that e.g. `debug` is a superset of `warn` with more detail. Is that
assumption false? Is it really necessary to force users to see stack traces in
the `warn` log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
