Tarun4201 commented on PR #13277:
URL: https://github.com/apache/maven/pull/13277#issuecomment-5857538256
@elharo Hi Elliot, thanks again for the thorough review! Here is a summary
of the updates made in commit 1eadd564 to address your feedback:
1. Entry Point Method: Introduced public static int run(String[] args,
ClassWorld world) as the primary and recommended entry point for CLAPP tools,
reserving main(...) and legacy signatures for compatibility.
2. 2. Documentation Updates: Updated clapp.md and README.txt to clearly
explain the CLAPP architecture, launcher usage (--clapp <toolname>), entry
points, and directory layout.
3. 3. URL protocol fix: Corrected http:// to https:// in clapp.md.
4. 4. Classpath Isolation: Clarified in documentation and responses that
${maven.home}/lib/clapp/<toolname>/ represents the pre-packaged distribution
structure for offline standalone tools, preventing core Maven/plexus classpath
contamination while .m2/repository remains available for dynamic artifact
resolution.
All inline review comments have been responded to accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
