Tarun4201 commented on PR #13277: URL: https://github.com/apache/maven/pull/13277#issuecomment-5874590442
Hi @gnodet, thank you for the review and for sharing the ClassWorlds realm architectural guidance! Before closing this PR, I wanted to respectfully request if the maintainers would consider reviewing and merging this implementation for **[MNG-8758](https://issues.apache.org/jira/browse/MNG-8758)**: 1. **Clean & Fully Passing CI**: - All Checkstyle and Spotless code formatting issues have been resolved. - All previous review / Copilot findings have been addressed in commit `ca84dc3d` (including fallback recursion prevention, child-first classloader isolation delegating core Maven and JDK classes, and dynamic JAR loading tests). 2. **General-Purpose & Extensible**: - The CLAPP mechanism provides a generic launcher protocol for any CLI extension or auxiliary tool residing in `lib/<tool>/` via `clapp.properties`, without requiring changes to Maven's core `m2.conf` descriptor for each individual tool. - It isolates tool-specific dependencies (such as `domtrip` for `mvnup`) from the main Maven build classpath while preserving full compatibility. Could the PMC consider this solution for merge, or is the decision final to reject generic CLI tool dispatch in favor of hardcoding `[plexus.mvnup]` in `m2.conf`? If the latter is strictly preferred, I will gladly close this PR and open a new one implementing the `[plexus.mvnup]` realm design. Thank you again for your time and feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
