Tarun4201 commented on PR #13277:
URL: https://github.com/apache/maven/pull/13277#issuecomment-5858012877
@elharo @gnodet-bot
Thanks for the reviews and feedback! Here is a summary of all updates made
to address the review comments:
1. **License URL Protocol**: Corrected `http://` to `https://` in `clapp.md`
(commit `1eadd564`).
2. 2. **CLAPP Naming & Purpose**: Updated `clapp.md` and `README.txt` to
clearly describe the architecture, launcher option (`--clapp`), entry points,
and directory layout structure.
3. 3. **Classpath Isolation & `.m2/repository`**: Clarified that
`${maven.home}/lib/clapp/<toolname>/` is specifically for pre-packaged
standalone tool distributions bundled with Maven to isolate tool classpaths,
while dynamic artifact resolution via `~/.m2/repository` remains fully
supported.
4. 4. **Entry Point Compatibility**: Implemented support for standard
`main(String[] args)` and `main(String[] args, ClassWorld world)` alongside
`run()`, with fallback resolution in `MavenClappCling.java` (commit `1eadd564`).
All inline comment threads have been addressed and resolved. Ready for
re-review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
