slachiewicz commented on PR #284: URL: https://github.com/apache/maven-artifact-plugin/pull/284#issuecomment-6626650301
The fix looks right, and both mirror tests fail without it. A few small things before merge: - The test calls Mockito's `lenient()` directly, so please declare `org.mockito:mockito-core` (4.11.0, since the build still runs on JDK 8) in test scope instead of relying on the harness bringing it in. - `slf4j-simple` isn't required by the harness. The tests pass without it and SLF4J only falls back to its no-op logger. Keeping it to silence that warning is fine, but please adjust the comment. - `@Execution(ExecutionMode.SAME_THREAD)` can go: the build doesn't run tests in parallel. - Optionally, check every repository's own id before checking mirrors, as suggested in #281. - Please use "Fixes #281" in the description so the issue closes on merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
