Ayush0612005 commented on PR #284: URL: https://github.com/apache/maven-artifact-plugin/pull/284#issuecomment-6629023054
@nielsbasjes I have now run the coverage against your **complete PR head `236a49f20516ddd10e5c587f01d49f0e8c412cf9`**, including its harness and dependency changes, and prepared a supporting test-only commit: https://github.com/Ayush0612005/maven-artifact-plugin/commit/8a55e7d8efc0c628e8b9d36efa04b881c898c360 It is a single commit directly on your head, ready to cherry-pick. It adds: - Three cases in your existing Mojo harness: selecting the mirror's own ID; finding a later original in a multi-repository mirror while retaining the exact effective repository object (including authentication/proxy/policies); and rejecting an unrelated mirror. - An Invoker fixture covering reproducible artifact installation, default `central`, the mirror ID, URL and `id::url` references, and the expected unknown-ID failure. The settings filename is deliberately distinct to avoid Invoker's shared interpolation filename collision. Validation on Windows 11, Maven 3.9.16 and JDK 25.0.1: - **12 unit tests passed**, no failures/errors/skips. - The complete integration run passed **16/18**, including the new fixture. The two existing Git-metadata fixtures failed because of local checkout/history problems. After fetching complete history into a normal clone, both passed on a targeted `verify` rerun, which finished with **BUILD SUCCESS**. Thus all 18 projects passed across the full run and affected-project rerun; I am not claiming a single uninterrupted 18/18 run. - Negative control: removing only your mirror fallback makes the fixture's first comparison fail with **`Could not find repository with id = central`**. The contribution retains your production code unchanged. Checkstyle, Spotless and RAT passed. Dependency analysis still warns about undeclared `mockito-core:4.11.0`, consistent with @slachiewicz's existing request. Artifact PGP verification was explicitly skipped locally. I haven't tested JDK 8 or a Maven 4 runtime. The earlier constructed exact-ID precedence probe still fails on your current implementation; it is deliberately excluded from this commit pending agreement on that optional behavior. No production/POM changes or parallel upstream PR are included. Please feel free to cherry-pick the commit, or use just the Invoker fixture if that fits this PR better. AI assistance: Codex helped prepare the test contribution, execute/check these results and draft this follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
