[
https://issues.apache.org/jira/browse/MESOS-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250990#comment-14250990
]
Benjamin Mahler commented on MESOS-1064:
----------------------------------------
Would love to enable unit-testing here. One idea is to pull out validators as a
series of functions. When we compose validators in the master, we bind in the
appropriate arguments for each validator. This means not all validators need to
take the same arguments, but we can invoke them through a no-argument function
operator, since they have everything bound in already. Those that don't need to
take internal master structs can then be unit tested.
Thoughts?
> Add tests for validation visitors in master
> -------------------------------------------
>
> Key: MESOS-1064
> URL: https://issues.apache.org/jira/browse/MESOS-1064
> Project: Mesos
> Issue Type: Improvement
> Components: master, test
> Reporter: Dominic Hamon
> Assignee: Dominic Hamon
> Priority: Minor
> Labels: c++, newbie, unit-test
>
> The various TaskInfoVisitor and OfferVisitor structures that are used for
> validation are untested. They should be pulled out from master.cpp into their
> own header(s) and unit tests need to be added.
> A rename to *Validator would be useful to as that's what they're used for.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
