[
https://issues.apache.org/jira/browse/MESOS-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252169#comment-14252169
]
Dominic Hamon commented on MESOS-1064:
--------------------------------------
I like the non-uniformity of validator construction as it makes it clear from
the call-site exactly what is being validated. In fact, I can imagine a world
where the validators don't take framework and slaves at all but pull data out
of them instead.
> Add tests for validation visitors in master
> -------------------------------------------
>
> Key: MESOS-1064
> URL: https://issues.apache.org/jira/browse/MESOS-1064
> Project: Mesos
> Issue Type: Improvement
> Components: master, test
> Reporter: Dominic Hamon
> Assignee: Dominic Hamon
> Priority: Minor
> Labels: c++, newbie, unit-test
>
> The various TaskInfoVisitor and OfferVisitor structures that are used for
> validation are untested. They should be pulled out from master.cpp into their
> own header(s) and unit tests need to be added.
> A rename to *Validator would be useful to as that's what they're used for.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
