[
https://issues.apache.org/jira/browse/MESOS-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251978#comment-14251978
]
Jie Yu commented on MESOS-1064:
-------------------------------
My concern with bind is that it assumes that the arguments are copyable. Not
sure about some 'framework' or 'slave' here are copyable or not. Also, bind
makes the construction of those validators not uniform.
> Add tests for validation visitors in master
> -------------------------------------------
>
> Key: MESOS-1064
> URL: https://issues.apache.org/jira/browse/MESOS-1064
> Project: Mesos
> Issue Type: Improvement
> Components: master, test
> Reporter: Dominic Hamon
> Assignee: Dominic Hamon
> Priority: Minor
> Labels: c++, newbie, unit-test
>
> The various TaskInfoVisitor and OfferVisitor structures that are used for
> validation are untested. They should be pulled out from master.cpp into their
> own header(s) and unit tests need to be added.
> A rename to *Validator would be useful to as that's what they're used for.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)