[
https://issues.apache.org/jira/browse/MESOS-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205960#comment-15205960
]
Fan Du commented on MESOS-4981:
-------------------------------
[~bbannier] Thanks for the quick review! :)
[~bmahler] Actually I have two questions here first:
1. Do we need to bump the metrics for failure cases of operation, e.g.
parameter sanity checks, authentication/authorization?
2. For the case of this ticket, we handle {{registerFramework}} and
{{reregisterFramework}} together in
{{[subscribe|https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob;f=src/master/master.cpp;h=e6290ea686ccf17813d6faeaf2f2012f79cf3b7f;hb=HEAD#l2256]}},
do we need to differentiate the metrics of {{registerFramework}} and
{{reregisterFramework}} strictly?
If "yes" to above two questions, IMO, we DO need Counter to be decremented for
above case, to accommodate for the implementation :)
I didn't know [~wangcong] has submit [r44473 |
https://reviews.apache.org/r/44473/], I think it could be beneficial at least
to my case here.
Here is my understanding about Counter and Gauge, though we didn't
differentiate them in Linux kernel. Use Counter for events or messages, and use
Gauge to get a snapshot of Resources by its name and meaning. It lost the
semantics if switching them over.
> Framework (re-)register metric counters broken for calls made via scheduler
> driver
> ----------------------------------------------------------------------------------
>
> Key: MESOS-4981
> URL: https://issues.apache.org/jira/browse/MESOS-4981
> Project: Mesos
> Issue Type: Bug
> Components: master
> Reporter: Anand Mazumdar
> Assignee: Fan Du
> Labels: mesosphere
>
> The counters {{master/messages_register_framework}} and
> {{master/messages_reregister_framework}} are no longer being incremented
> after the scheduler driver started sending {{Call}} messages to the master in
> Mesos 0.23. We should correctly be incrementing these counters for PID based
> frameworks as was the case previously.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
