[
https://issues.apache.org/jira/browse/MESOS-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209672#comment-15209672
]
Fan Du commented on MESOS-4981:
-------------------------------
hmm, here is the scenario, I can explain :)
When framework call SUBSCRIBE, it could be register a newborn framework, or it
could also possibly updating(reregistering) a framework.
For {{subscribe}} the flow is:
{code}
1. bump messages_register_framework
2. Various of sanity check
3. Newborn framework?
3a. Add new framework
3b. Return
4. Roll back messages_register_framework, and add
messages_reregister_framework
5. Otherwise framework is reregistering
5a. Updating the framework
5b. Return
{code}
That's why I ask two questions above:
q1. Does metrics has to counter fail cases like sanity check? If no, we can
fairly bump the metrics when we are sure it's a good/clean operation
in 3a, and 5a. But from the conventions how other metrics are countered,
metrics includes all other fail cases like sanity check.
q2. Is it ok to update messages_register_framework, even though it's already
know the operation should bump messages_reregister_framework?
that's being said, do not need to roll back messages_register_framework
again?
> Framework (re-)register metric counters broken for calls made via scheduler
> driver
> ----------------------------------------------------------------------------------
>
> Key: MESOS-4981
> URL: https://issues.apache.org/jira/browse/MESOS-4981
> Project: Mesos
> Issue Type: Bug
> Components: master
> Reporter: Anand Mazumdar
> Assignee: Fan Du
> Labels: mesosphere
>
> The counters {{master/messages_register_framework}} and
> {{master/messages_reregister_framework}} are no longer being incremented
> after the scheduler driver started sending {{Call}} messages to the master in
> Mesos 0.23. We should correctly be incrementing these counters for PID based
> frameworks as was the case previously.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
