[ 
https://issues.apache.org/jira/browse/MESOS-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209630#comment-15209630
 ] 

Benjamin Mahler commented on MESOS-4981:
----------------------------------------

I don't follow why you're subtracting in 
[r/45097|https://reviews.apache.org/r/45097/], it seems like a hack? Seeing the 
counter for registrations go up and then back down is going to cause confusion.

> Framework (re-)register metric counters broken for calls made via scheduler 
> driver
> ----------------------------------------------------------------------------------
>
>                 Key: MESOS-4981
>                 URL: https://issues.apache.org/jira/browse/MESOS-4981
>             Project: Mesos
>          Issue Type: Bug
>          Components: master
>            Reporter: Anand Mazumdar
>            Assignee: Fan Du
>              Labels: mesosphere
>
> The counters {{master/messages_register_framework}} and 
> {{master/messages_reregister_framework}} are no longer being incremented 
> after the scheduler driver started sending {{Call}} messages to the master in 
> Mesos 0.23. We should correctly be incrementing these counters for PID based 
> frameworks as was the case previously.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to