[
https://issues.apache.org/jira/browse/METRON-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288397#comment-16288397
]
ASF GitHub Bot commented on METRON-1340:
----------------------------------------
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/857
I was reviewing the protractor documentation
[here](http://www.protractortest.org/#/async-await) and I noticed this:
> Don’t forget to turn off control_flow, you cannot use a mix of
async/await and the control flow: async/await causes the control flow to become
unreliable (see github issue). So if you async/await anywhere in a spec, you
should use the SELENIUM_PROMISE_MANAGER: false
I don't see that setting in protractor.conf.js. Shouldn't it be included?
Have all the tests been updated to use async/await instead of web driver flow
control?
> Improve e2e tests for metron alerts
> -----------------------------------
>
> Key: METRON-1340
> URL: https://issues.apache.org/jira/browse/METRON-1340
> Project: Metron
> Issue Type: Bug
> Reporter: RaghuMitra
> Assignee: RaghuMitra
>
> Need to improve e2e tests in the following areas:
> - Tests should not be flaky
> - Remove the sleep ( This should implicitly make the tests run faster)
> - Truncate HBase table 'metron_update' before starting the tests
> - Improve the tests descriptions
> - Run the tests headless if possible
> - Check the node version and browser version before launching the tests
> The expected behavior is that there are no intermittent failures. Acceptance
> criteria: 5 consecutive runs without failures.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)