[
https://issues.apache.org/jira/browse/METRON-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289442#comment-16289442
]
ASF GitHub Bot commented on METRON-1340:
----------------------------------------
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/857
Follow up from @merrimanr and my work yesterday. We upped the versions of
Node to 9.2.1. Per the doc, >8 is required to work with async/await. For good
measure, I also set the NPM version to 5.6.0. We didn't touch Jasmine, but the
Protractor docs also state that it should be > 2.7. Looks like we are currently
using 2.5.2 per the package.json file. We may want to consider increasing that
version as well.
We added `SELENIUM_PROMISE_MANAGER: false` to `protractor.conf.js` and
immediately got failures due to `Promise` use in the Protractor tests and
configuration. e.g. `var defer = protractor.promise.defer();`. So we removed
references to promises in the conf file and were able to get past that first
batch of errors. Now we were into problems with the tests. I started with the
`login.e2e-spec.ts` spec file and removed `: Promise<any>`. Running the tests
again, the login tests were able to succeed.
There are still a large number of failures due to disabling the promise
manager, but still having code throughout the test suite that leverages the
older style. It's unclear if this will resolve all stability issues, but I
think this is moving in the right direction.
> Improve e2e tests for metron alerts
> -----------------------------------
>
> Key: METRON-1340
> URL: https://issues.apache.org/jira/browse/METRON-1340
> Project: Metron
> Issue Type: Bug
> Reporter: RaghuMitra
> Assignee: RaghuMitra
>
> Need to improve e2e tests in the following areas:
> - Tests should not be flaky
> - Remove the sleep ( This should implicitly make the tests run faster)
> - Truncate HBase table 'metron_update' before starting the tests
> - Improve the tests descriptions
> - Run the tests headless if possible
> - Check the node version and browser version before launching the tests
> The expected behavior is that there are no intermittent failures. Acceptance
> criteria: 5 consecutive runs without failures.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
