[
https://issues.apache.org/jira/browse/METRON-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471042#comment-16471042
]
ASF GitHub Bot commented on METRON-1549:
----------------------------------------
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1009
@nickwallen and @ottobackwards - I extracted the common setup components
into one parameterized method. I opted for setting private test class fields
with the components rather than invoking getComponent() because I thought it
was a bit cleaner. I also looked at doing this in @Before and @After setup
methods, but setup for each of the tests changes on a per-test basis.
We're currently employing a useful builder pattern to configure the test
components/infrastructure which generally means you provide invariants and then
build the object from them. It might also be worthwhile to look at a way to use
the builder pattern, but also change certain aspects of the setup within the
individual test cases, e.g. upload a new global config after spinning up the
components. This could make it more efficient to run multiple tests by using
@Before and @After to spin things up to run a battery of similar integration
tests. Do you guys think we need it for this test change?
> Add empty object test to WriterBoltIntegrationTest implementation
> -----------------------------------------------------------------
>
> Key: METRON-1549
> URL: https://issues.apache.org/jira/browse/METRON-1549
> Project: Metron
> Issue Type: Test
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
> Priority: Major
>
> Verify expected output when empty objects returned by custom parsers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
