[
https://issues.apache.org/jira/browse/METRON-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470407#comment-16470407
]
ASF GitHub Bot commented on METRON-1549:
----------------------------------------
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/1009#discussion_r187335697
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/writers/integration/WriterBoltIntegrationTest.java
---
@@ -88,9 +108,7 @@ public void initialize(Map<String, Object>
validationConfig, Map<String, Object>
public static String parserConfigJSON;
@Test
- public void test() throws UnableToStartException, IOException,
ParseException {
-
- UnitTestHelper.setLog4jLevel(CSVParser.class,
org.apache.log4j.Level.FATAL);
+ public void
parser_with_global_validations_writes_bad_records_to_error_topic() throws
Exception {
--- End diff --
I think the quantity of code is mainly due to the existing setup code. I'm
happy to refactor that. I really don't like adding or reading javadoc where
code can communicate clearly. I think it's redundant to add it where method and
class names can appropriately capture the intent. With extracting out the
common setup code and the Processor logic, does the test name you've referenced
on line 111 along with the test assertions make it clear enough?
> Add empty object test to WriterBoltIntegrationTest implementation
> -----------------------------------------------------------------
>
> Key: METRON-1549
> URL: https://issues.apache.org/jira/browse/METRON-1549
> Project: Metron
> Issue Type: Test
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
> Priority: Major
>
> Verify expected output when empty objects returned by custom parsers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
