[
https://issues.apache.org/jira/browse/METRON-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474753#comment-16474753
]
ASF GitHub Bot commented on METRON-1548:
----------------------------------------
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1010#discussion_r188086075
--- Diff:
metron-interface/metron-alerts/src/app/service/global-config.service.ts ---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import {Injectable, Inject} from '@angular/core';
+import {Http, Headers, RequestOptions, Response, ResponseOptions} from
'@angular/http';
+import {Observable} from 'rxjs/Observable';
+import {HttpUtil} from '../utils/httpUtil';
+
+@Injectable()
+export class GlobalConfigService {
+ url = 'api/v1/global/config';
+ defaultHeaders = {'Content-Type': 'application/json',
'X-Requested-With': 'XMLHttpRequest'};
+
+ private globalConfig = {};
+
+ constructor(private http: Http) {
--- End diff --
I think this constructor was carried over from metron-config and the
property assignments are not needed. I think it should just be empty.
> Alerts UI: Remove hardcoded source:type and other fields that may vary
> ----------------------------------------------------------------------
>
> Key: METRON-1548
> URL: https://issues.apache.org/jira/browse/METRON-1548
> Project: Metron
> Issue Type: Sub-task
> Reporter: Justin Leet
> Priority: Major
>
> In Solr, we use source.type instead of source:type (which was originally due
> to ES limitations, we'd prefer it to be common across both). However, it's
> hardcoded in the alerts UI to be source:type, so nothing in the UI has a
> source type and it breaks other things like metaalerts (which rely on source
> type for being able to pull the data together).
> Any other configs / queries that would cause similar problems should be
> updated appropriately.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
