[ 
https://issues.apache.org/jira/browse/METRON-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475955#comment-16475955
 ] 

ASF GitHub Bot commented on METRON-1548:
----------------------------------------

Github user justinleet commented on the issue:

    https://github.com/apache/metron/pull/1010
  
    I spun this up, changed the config, restarted the UI and had a couple 
comments.
    
    1. Every time you log in, it keeps adding new source.type fields in the 
table. Unselecting these in the options doesn't work properly (only the top one 
toggles no matter which I click on).  Possibly doubles every time?
    2. The filters on the left still say "source:type", even after the config 
is changed.
    3. The group by still says "source:type", even after the config is changed. 
This grouping still works fine (which I would expect if it's still grouping on 
source:type).
    
    I would expect both the filter and group by to act on the configured 
`source.type.field` by default.  Otherwise, the user has to know what's going 
on and change it manually.
    
    I'd also like to add a bit in the documentation that updating the 
`source.type.field` requires a UI restart.  This is pretty typical of the UI, 
but most global config things get picked up automagically (e.g. topology 
changes and such), so a quick blurb would be nice.


> Alerts UI: Remove hardcoded source:type and other fields that may vary
> ----------------------------------------------------------------------
>
>                 Key: METRON-1548
>                 URL: https://issues.apache.org/jira/browse/METRON-1548
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Justin Leet
>            Priority: Major
>
> In Solr, we use source.type instead of source:type (which was originally due 
> to ES limitations, we'd prefer it to be common across both). However, it's 
> hardcoded in the alerts UI to be source:type, so nothing in the UI has a 
> source type and it breaks other things like metaalerts (which rely on source 
> type for being able to pull the data together).
> Any other configs / queries that would cause similar problems should be 
> updated appropriately.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to