[ 
https://issues.apache.org/jira/browse/METRON-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479559#comment-16479559
 ] 

ASF GitHub Bot commented on METRON-1548:
----------------------------------------

Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1010#discussion_r189065371
  
    --- Diff: 
metron-interface/metron-alerts/src/app/alerts/alerts-list/alerts-list.component.ts
 ---
    @@ -174,6 +177,13 @@ export class AlertsListComponent implements OnInit, 
OnDestroy {
       }
     
       ngOnInit() {
    +    this.globalConfigService.get().subscribe((config: {}) => {
    +      this.globalConfig = config;
    +      if (this.globalConfig['source.type.field'] === 'source.type' && 
!this.alertsColumns['source.type']) {
    --- End diff --
    
    Same as https://github.com/apache/metron/pull/1010/files#r189060226


> Alerts UI: Remove hardcoded source:type and other fields that may vary
> ----------------------------------------------------------------------
>
>                 Key: METRON-1548
>                 URL: https://issues.apache.org/jira/browse/METRON-1548
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Justin Leet
>            Priority: Major
>
> In Solr, we use source.type instead of source:type (which was originally due 
> to ES limitations, we'd prefer it to be common across both). However, it's 
> hardcoded in the alerts UI to be source:type, so nothing in the UI has a 
> source type and it breaks other things like metaalerts (which rely on source 
> type for being able to pull the data together).
> Any other configs / queries that would cause similar problems should be 
> updated appropriately.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to