[
https://issues.apache.org/jira/browse/METRON-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571950#comment-16571950
]
ASF GitHub Bot commented on METRON-1704:
----------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1146#discussion_r208304304
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/DefaultMessageDistributor.java
---
@@ -146,16 +146,14 @@ public DefaultMessageDistributor(
/**
* Distribute a message along a MessageRoute.
*
- * @param message The message that needs distributed.
- * @param timestamp The timestamp of the message.
* @param route The message route.
* @param context The Stellar execution context.
*/
@Override
- public void distribute(JSONObject message, long timestamp, MessageRoute
route, Context context) {
+ public void distribute(MessageRoute route, Context context) {
--- End diff --
The `MessageRoute` abstraction now contains both the message (a JSONObject)
and the timestamp (a Long). Previously this was passed along separately. It
is much simpler for all of the ports (Spark included) to wrap this all into the
`MessageRoute`.
> Message Timestamp Logic Should be Shared
> ----------------------------------------
>
> Key: METRON-1704
> URL: https://issues.apache.org/jira/browse/METRON-1704
> Project: Metron
> Issue Type: Sub-task
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> The message timestamp logic is currently duplicated across both ports of the
> Profiler; the REPL and Storm. This should be pulled into
> metron-profiler-common so that the logic can be shared and also used by the
> Spark port.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
