[
https://issues.apache.org/jira/browse/METRON-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571953#comment-16571953
]
ASF GitHub Bot commented on METRON-1704:
----------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1146#discussion_r208304859
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/DefaultMessageRouter.java
---
@@ -53,10 +56,16 @@
*/
private StellarStatefulExecutor executor;
+ /**
+ * Responsible for creating the {@link Clock}.
+ */
+ private ClockFactory clockFactory;
--- End diff --
The `ClockFactory` helps with the timestamp logic. This used to live in
the `ProfileSplitterBolt` as that is where the timestamp extract logic lived.
Now the `MessageRouter` does this for all Profiler ports.
> Message Timestamp Logic Should be Shared
> ----------------------------------------
>
> Key: METRON-1704
> URL: https://issues.apache.org/jira/browse/METRON-1704
> Project: Metron
> Issue Type: Sub-task
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> The message timestamp logic is currently duplicated across both ports of the
> Profiler; the REPL and Storm. This should be pulled into
> metron-profiler-common so that the logic can be shared and also used by the
> Spark port.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
