[
https://issues.apache.org/jira/browse/METRON-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574794#comment-16574794
]
ASF GitHub Bot commented on METRON-1704:
----------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1146#discussion_r208915112
--- Diff:
metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileSplitterBolt.java
---
@@ -162,15 +156,9 @@ private void doExecute(Tuple input) throws
ParseException, UnsupportedEncodingEx
// ensure there is a valid profiler configuration
ProfilerConfig config = getProfilerConfig();
if(config != null && config.getProfiles().size() > 0) {
+ routeMessage(input, message, config);
- // what time is it?
--- End diff --
Here I removed the timestamp logic from Storm. The `MessageRouter` does
this for us now.
> Message Timestamp Logic Should be Shared
> ----------------------------------------
>
> Key: METRON-1704
> URL: https://issues.apache.org/jira/browse/METRON-1704
> Project: Metron
> Issue Type: Sub-task
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> The message timestamp logic is currently duplicated across both ports of the
> Profiler; the REPL and Storm. This should be pulled into
> metron-profiler-common so that the logic can be shared and also used by the
> Spark port.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
