[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581228#comment-16581228
]
ASF GitHub Bot commented on METRON-1724:
----------------------------------------
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1165#discussion_r210306465
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts
---
@@ -263,10 +230,10 @@ describe('PcapFiltersComponent', () => {
model: new SimpleChange(null, newModel, false)
});
- expect(component.startTimeStr).toBe(startTimeStr);
- expect(component.endTimeStr).toBe(endTimeStr);
- expect(component.ipSrcPort).toBe('');
- expect(component.ipDstPort).toBe('');
+
expect(component.filterForm.controls.startTime.value).toBe(startTimeStr);
+ expect(component.filterForm.controls.endTime.value).toBe(endTimeStr);
+ expect(component.filterForm.controls.ipSrcPort.value).toBe(0);
--- End diff --
Why would we want the ports to be 0 here? This query is incorrect.
> Date/time validation missing in PCAP query
> ------------------------------------------
>
> Key: METRON-1724
> URL: https://issues.apache.org/jira/browse/METRON-1724
> Project: Metron
> Issue Type: Bug
> Reporter: Tibor Meller
> Priority: Major
>
> Validation formula should be the following:
> From < To < current date/time
>
> Validation messages:
> Selected date range is invalid. The "To" date must be later than the "From"
> date and the "To" date cannot be in the future.
> Source IP address format is invalid. Use valid v4IP format, for example,
> [192.168.0.1|http://192.168.0.1/].
> Source port is invalid. Port number must be within the range of 0-65535.
> Destination IP address format is invalid. Use valid v4IP format, for example,
> [192.168.0.1|http://192.168.0.1/].
> Destination port is invalid. Port number must be within the range of 0-65535.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
