[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581510#comment-16581510
]
ASF GitHub Bot commented on METRON-1724:
----------------------------------------
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1165#discussion_r210379924
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest {
- startTimeMs: number = 0;
- endTimeMs: number = 150000000000000000;
- ipSrcAddr: string = '';
- ipSrcPort: number;
- ipDstAddr: string = '';
- ipDstPort: number;
- protocol: string = '';
- packetFilter: string = '';
- includeReverse: boolean = false;
+ startTimeMs = 0;
+ endTimeMs = 150000000000000000;
+ ipSrcAddr = '';
+ ipSrcPort = 0;
--- End diff --
These default values was part of the handovered implementation. It haven't
caused issues till now. Anyway these defaults makes no sense to me eigther.
I'll fix it retest against the latest full dev.
> Date/time validation missing in PCAP query
> ------------------------------------------
>
> Key: METRON-1724
> URL: https://issues.apache.org/jira/browse/METRON-1724
> Project: Metron
> Issue Type: Bug
> Reporter: Tibor Meller
> Priority: Major
>
> Validation formula should be the following:
> From < To < current date/time
>
> Validation messages:
> Selected date range is invalid. The "To" date must be later than the "From"
> date and the "To" date cannot be in the future.
> Source IP address format is invalid. Use valid v4IP format, for example,
> [192.168.0.1|http://192.168.0.1/].
> Source port is invalid. Port number must be within the range of 0-65535.
> Destination IP address format is invalid. Use valid v4IP format, for example,
> [192.168.0.1|http://192.168.0.1/].
> Destination port is invalid. Port number must be within the range of 0-65535.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
