[ 
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581230#comment-16581230
 ] 

ASF GitHub Bot commented on METRON-1724:
----------------------------------------

Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1165#discussion_r210306554
  
    --- Diff: 
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts
 ---
    @@ -179,19 +171,6 @@ describe('PcapFiltersComponent', () => {
         component.onSubmit();
       });
     
    -  it('Port fields should be removed from request when set to empty', () => 
{
    --- End diff --
    
    Why was this test removed?  This was added to catch a regression introduced 
in a previous PR.  Now this test is gone and the regression is back!


> Date/time validation missing in PCAP query
> ------------------------------------------
>
>                 Key: METRON-1724
>                 URL: https://issues.apache.org/jira/browse/METRON-1724
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Tibor Meller
>            Priority: Major
>
> Validation formula should be the following: 
>  From < To < current date/time
>  
> Validation messages:
> Selected date range is invalid. The "To" date must be later than the "From" 
> date and the "To" date cannot be in the future.
> Source IP address format is invalid. Use valid v4IP format, for example, 
> [192.168.0.1|http://192.168.0.1/].
> Source port is invalid. Port number must be within the range of 0-65535.
> Destination IP address format is invalid. Use valid v4IP format, for example, 
> [192.168.0.1|http://192.168.0.1/].
> Destination port is invalid. Port number must be within the range of 0-65535.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to