Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1190#discussion_r216090450
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java
---
@@ -121,20 +131,30 @@ public void addCommentToAlert(CommentAddRemoveRequest
request, Document latest)
if (exceptions.size() > 0) {
throw new IOException(Joiner.on("\n").join(exceptions));
}
+ return newVersions.get(0);
--- End diff --
Here we are collecting each updated document in a list. In theory they are
all the same so it shouldn't matter which one we return. Is there a better way
to do this?
---
