Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1190#discussion_r216090740
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/metaalert/lucene/AbstractLuceneMetaAlertUpdateDao.java
---
@@ -170,21 +169,51 @@ protected Document
buildCreateDocument(Iterable<Document> alerts, List<String> g
return updates;
}
+ /**
+ * Adds alerts to a metaalert, based on a list of GetRequests provided
for retrieval.
+ * @param metaAlertGuid The GUID of the metaalert to be given new
children.
+ * @param alertRequests GetRequests for the appropriate alerts to add.
+ * @return The updated metaalert with alerts added.
+ */
+ @Override
+ public Document addAlertsToMetaAlert(String metaAlertGuid,
List<GetRequest> alertRequests)
--- End diff --
This was moved from the Elasticsearch Dao implementation essentially making
it the default method for adding alerts to metaalerts (the logic in the Solr
implementation is different). This allows us to reuse this code in the
InMemory implementation.
---
