[
https://issues.apache.org/jira/browse/METRON-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627291#comment-16627291
]
ASF GitHub Bot commented on METRON-1792:
----------------------------------------
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1211
METRON-1792 Simplify Profile Definitions in Integration Tests
It would be easier to read the ProfilerIntegrationTest if the profile
definitions were defined 'inline' rather than in separate configuration files.
This was [feedback](
https://github.com/apache/metron/pull/1174#discussion_r215456000) that was
offered as part of another code review.
## Testing
This only changes the integration tests. If those tests pass, we should be
happy.
## Pull Request Checklist
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1792
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1211.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1211
----
commit cb492222dbd12686646ab052a1f6dfdf5c2d7744
Author: Nick Allen <nick@...>
Date: 2018-09-24T22:51:36Z
METRON-1791 Add GUID to Messages Produced by Profiler
commit 2cc5ab577633d6f55a90a3afa9e92a3a4c4028d9
Author: Nick Allen <nick@...>
Date: 2018-09-25T11:43:59Z
Added integration test to validate triage messages
commit 48df90b671c59b643625f58e5e3f7791e1d16320
Author: Nick Allen <nick@...>
Date: 2018-09-25T12:53:24Z
METRON-1792 Simplify Profile Definitions in Integration Tests
----
> Simplify Profile Definitions in Integration Tests
> -------------------------------------------------
>
> Key: METRON-1792
> URL: https://issues.apache.org/jira/browse/METRON-1792
> Project: Metron
> Issue Type: Improvement
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> It would be easier to read the ProfilerIntegrationTest if the profile
> definitions were defined 'inline' rather than in separate configuration
> files.
>
> This was feedback that was offered as part of another code review;
> https://github.com/apache/metron/pull/1174#discussion_r215456000
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
