[
https://issues.apache.org/jira/browse/METRON-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642520#comment-16642520
]
ASF GitHub Bot commented on METRON-1792:
----------------------------------------
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1211
Love it @nickwallen. +1 via inspection from me. Much improved readability
and very easy to see the full context of the test from this change without
needing to open up separate files.
> Simplify Profile Definitions in Integration Tests
> -------------------------------------------------
>
> Key: METRON-1792
> URL: https://issues.apache.org/jira/browse/METRON-1792
> Project: Metron
> Issue Type: Improvement
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> It would be easier to read the ProfilerIntegrationTest if the profile
> definitions were defined 'inline' rather than in separate configuration
> files.
>
> This was feedback that was offered as part of another code review;
> https://github.com/apache/metron/pull/1174#discussion_r215456000
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
