[
https://issues.apache.org/jira/browse/METRON-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642511#comment-16642511
]
ASF GitHub Bot commented on METRON-1792:
----------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1211#discussion_r223501886
--- Diff:
metron-analytics/metron-profiler-storm/src/test/java/org/apache/metron/profiler/storm/integration/ConfigUploadComponent.java
---
@@ -117,8 +127,13 @@ public ConfigUploadComponent
withGlobalConfiguration(String path) {
return this;
}
- public ConfigUploadComponent withProfilerConfiguration(String path) {
- this.profilerConfiguration = path;
+ public ConfigUploadComponent withProfilerConfigurationPath(String path) {
--- End diff --
I needed this to let me upload the profile definitions, which for the
integration tests, are just Strings.
> Simplify Profile Definitions in Integration Tests
> -------------------------------------------------
>
> Key: METRON-1792
> URL: https://issues.apache.org/jira/browse/METRON-1792
> Project: Metron
> Issue Type: Improvement
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> It would be easier to read the ProfilerIntegrationTest if the profile
> definitions were defined 'inline' rather than in separate configuration
> files.
>
> This was feedback that was offered as part of another code review;
> https://github.com/apache/metron/pull/1174#discussion_r215456000
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
