nickwallen commented on a change in pull request #1458: METRON-2177 Upgrade
Profiler for HBase 2.0.2
URL: https://github.com/apache/metron/pull/1458#discussion_r306311766
##########
File path:
metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/ProfilerClient.java
##########
@@ -23,13 +23,14 @@
import org.apache.metron.profiler.ProfileMeasurement;
import org.apache.metron.profiler.ProfilePeriod;
+import java.io.Closeable;
import java.util.List;
import java.util.Optional;
/**
* An interface for a client capable of retrieving the profile data that has
been persisted by the Profiler.
*/
-public interface ProfilerClient {
+public interface ProfilerClient extends Closeable {
Review comment:
Needs to be closable so that the underlying Hbase connections can be
cleaned-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
