nickwallen commented on a change in pull request #1458: METRON-2177 Upgrade
Profiler for HBase 2.0.2
URL: https://github.com/apache/metron/pull/1458#discussion_r311053614
##########
File path:
metron-analytics/metron-profiler-storm/src/test/java/org/apache/metron/profiler/storm/integration/ProfilerIntegrationTest.java
##########
@@ -503,21 +496,29 @@ public void setup() {
put(PROFILER_SALT_DIVISOR.getKey(), saltDivisor);
}};
+ Context context = new Context.Builder()
+ .with(Context.Capabilities.GLOBAL_CONFIG, () -> global)
+ .build();
+
+ // create the GET_PROFILE function
+ GetProfile getProfileFunction = new GetProfile()
+ .withProfilerClientFactory(new HBaseProfilerClientFactory(new
FakeHBaseClientFactory()));
Review comment:
Different tests needed different replacements. But in many cases, especially
the integration tests, using a `FakeHBaseClient` is the replacement for the
"mock Hbase table stuff".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
