nickwallen commented on a change in pull request #1458: METRON-2177 Upgrade 
Profiler for HBase 2.0.2
URL: https://github.com/apache/metron/pull/1458#discussion_r306324602
 
 

 ##########
 File path: 
metron-analytics/metron-profiler-storm/src/main/java/org/apache/metron/hbase/bolt/HBaseBolt.java
 ##########
 @@ -76,60 +77,67 @@
   protected HBaseMapper mapper;
 
   /**
-   * The name of the class that should be used as a table provider.
-   *
-   * <p>Defaults to 'org.apache.metron.hbase.HTableProvider'.
+   * Defines when a batch needs flushed.
    */
-  protected String tableProviderClazzName = 
"org.apache.metron.hbase.HTableProvider";
+  private BatchHelper batchHelper;
 
   /**
-   * The TableProvider
-   * May be loaded from tableProviderClazzName or provided
+   * Establishes a connection to HBase.
    */
-  protected TableProvider tableProvider;
+  private HBaseConnectionFactory connectionFactory;
+
+  /**
+   * Creates the {@link HBaseTableClient} used by this bolt.
+   */
+  private HBaseClientFactory hBaseClientFactory;
+
+  /**
+   * Used to write to HBase.
+   */
+  protected transient HBaseClient hbaseClient;
 
 Review comment:
   Made the "Streaming Profiler" use the new `HbaseClient` abstraction.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to