tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327001281
##########
File path:
metron-interface/metron-alerts/src/app/alerts/alerts-list/alerts-list.component.ts
##########
@@ -226,8 +259,6 @@ export class AlertsListComponent implements OnInit,
OnDestroy {
onClear() {
this.timeStampFilterPresent = false;
this.queryBuilder.clearSearch();
- if (this.hideQueryBuilder) { this.manualQuery.nativeElement.value = '*'; }
Review comment:
Source of manual query string is no longer the native dom element. I moved
it to query builder to eliminate the two posibble source of query. Logic
belongs to query creations is inside query builder to encapsulate and not make
alerts-list more bloated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
