tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r326993769
##########
File path:
metron-interface/metron-alerts/src/app/alerts/alerts-list/alerts-list.component.scss
##########
@@ -197,27 +197,6 @@ $searchbox-height: 42px;
cursor: pointer;
}
-.pause-play {
- height: 38px;
- padding: 0px;
- border: 1px solid #0F6F9E;
- width: 38px;
- line-height: 39px;
- border-radius: 12px;
- margin-left: 15px;
- background: $mine-shaft-2;
- cursor: pointer;
-
- i {
- font-size: 17px;
- color: $piction-blue;
- }
-
- .fa-play {
- padding-left: 3px;
- }
-}
-
Review comment:
alerts-list.component is extremely big. I introduced an
auto-polling.component to encapsulate visual aspect of auto polling and make
alerts-list little bit smaller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
