tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327017385
##########
File path:
metron-interface/metron-alerts/src/app/alerts/configure-rows/configure-rows.component.ts
##########
@@ -16,53 +16,29 @@
* limitations under the License.
*/
import { Component, Input, HostListener, ElementRef, Output, EventEmitter }
from '@angular/core';
-import { TableMetadata } from '../../model/table-metadata';
-import { ConfigureTableService } from '../../service/configure-table.service';
+export interface ConfigureRowsModel {
+ values: {
+ pageSize: number;
+ refreshInterval: number;
+ },
+ triggerQuery: boolean
+}
@Component({
selector: 'app-configure-rows',
templateUrl: './configure-rows.component.html',
styleUrls: ['./configure-rows.component.scss']
})
export class ConfigureRowsComponent {
-
showView = false;
- tableMetadata = new TableMetadata();
@Input() srcElement: HTMLElement;
- @Output() sizeChange = new EventEmitter();
- @Output() intervalChange = new EventEmitter();
- @Output() configRowsChange = new EventEmitter();
-
- constructor(private elementRef: ElementRef,
- private configureTableService: ConfigureTableService) {}
-
- @Input()
- get size() {
- return this.tableMetadata.size;
- }
+ @Input() pageSize: number;
+ @Input() refreshInterval: number;
- set size(val) {
- this.tableMetadata.size = val;
- }
+ @Output() configRowsChange = new EventEmitter<ConfigureRowsModel>();
- @Input()
- get interval() {
- return this.tableMetadata.refreshInterval;
- }
-
- set interval(val) {
- this.tableMetadata.refreshInterval = val;
- }
-
- @Input()
- get tableMetaData() {
- return this.tableMetadata;
- }
-
- set tableMetaData(val) {
Review comment:
tableMetaData is no directly used by this component so I refactored it out.
Changes here was needed to separate config change events we like to trigger
query from others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
