[ 
https://issues.apache.org/jira/browse/METRON-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851692#comment-15851692
 ] 

ASF GitHub Bot commented on METRON-684:
---------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/435#discussion_r99367666
  
    --- Diff: 
metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/FixedLookback.java
 ---
    @@ -0,0 +1,74 @@
    +/*
    + *
    + *  Licensed to the Apache Software Foundation (ASF) under one
    + *  or more contributor license agreements.  See the NOTICE file
    + *  distributed with this work for additional information
    + *  regarding copyright ownership.  The ASF licenses this file
    + *  to you under the Apache License, Version 2.0 (the
    + *  "License"); you may not use this file except in compliance
    + *  with the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *  Unless required by applicable law or agreed to in writing, software
    + *  distributed under the License is distributed on an "AS IS" BASIS,
    + *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    + *  See the License for the specific language governing permissions and
    + *  limitations under the License.
    + *
    + */
    +package org.apache.metron.profiler.client.stellar;
    +
    +import org.apache.metron.common.dsl.Context;
    +import org.apache.metron.common.dsl.ParseException;
    +import org.apache.metron.common.dsl.Stellar;
    +import org.apache.metron.common.dsl.StellarFunction;
    +import org.apache.metron.profiler.ProfilePeriod;
    +
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Optional;
    +import java.util.concurrent.TimeUnit;
    +
    +@Stellar(
    +      namespace="PROFILE",
    +      name="FIXED",
    +      description="The profiler periods associated with a fixed lookback 
starting from now.",
    +      params={
    +        "durationAgo - How long ago should values be retrieved from?",
    +        "units - The units of 'durationAgo'.",
    +        "config_overrides - Optional - Map (in curly braces) of name:value 
pairs, each overriding the global config parameter " +
    +                "of the same name. Default is the empty Map, meaning no 
overrides."
    +      },
    +      returns="The selected profile measurement periods."
    --- End diff --
    
    Also, describing the type here would be good too.


> Decouple Timestamp calculation from PROFILE_GET
> -----------------------------------------------
>
>                 Key: METRON-684
>                 URL: https://issues.apache.org/jira/browse/METRON-684
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Casey Stella
>            Assignee: Casey Stella
>
> Currently PROFILE_GET only supports a static lookback of a fixed duration.  
> As we have more complicated, potentially sparse, lookbacks (e.g. the same 
> time slice every tuesday for a month), it would be nice to decouple the 
> construction of timestamps from PROFILE_GET into its own set of functions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to