[ 
https://issues.apache.org/jira/browse/METRON-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851690#comment-15851690
 ] 

ASF GitHub Bot commented on METRON-684:
---------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/435#discussion_r99366827
  
    --- Diff: metron-analytics/metron-profiler-client/README.md ---
    @@ -29,8 +29,7 @@ The Stellar client consists of the `PROFILE_GET` command, 
which takes the follow
     REQUIRED:
         profile - The name of the profile
         entity - The name of the entity
    -    durationAgo - How long ago should values be retrieved from?
    -    units - The units of 'durationAgo'
    +    periods - The list of profile periods to grab
    --- End diff --
    
    Would be good to mention what type 'periods' is; aka epoch milliseconds.


> Decouple Timestamp calculation from PROFILE_GET
> -----------------------------------------------
>
>                 Key: METRON-684
>                 URL: https://issues.apache.org/jira/browse/METRON-684
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Casey Stella
>            Assignee: Casey Stella
>
> Currently PROFILE_GET only supports a static lookback of a fixed duration.  
> As we have more complicated, potentially sparse, lookbacks (e.g. the same 
> time slice every tuesday for a month), it would be nice to decouple the 
> construction of timestamps from PROFILE_GET into its own set of functions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to