mcarrickscott commented on PR #95: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/95#issuecomment-1449553134
Furthermore if you insist on compiling with a flag that causes the compiler to do insert overflow checks on every integer operation, then the extra code inserted by the compiler will have a massive impact on performance. Maybe better to go with Rust which has no undefined behaviour, and which will just do the left shift without complaint. Mike On Wed, Mar 1, 2023 at 12:20 PM Matthias Görgens ***@***.***> wrote: > @mcarrickscott <https://github.com/mcarrickscott> What makes you think > that the -fno-strict-overflow doesn't exist in GCC? It's in the > documentation, and GCC accepts it when I try it. > > Let me give you an example where your assumption about shifts breaks down. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-milagro-crypto-c/pull/95#issuecomment-1449540761>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAU3ZDW7Q2NCLJXCFA6LV63WZ4BEXANCNFSM6AAAAAATEDLYUI> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
