mcarrickscott commented on PR #95: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/95#issuecomment-1449574180
Then how can you be sure that undefined behaviour will not occur in the release version? You may test with the sanitizer on, but conditions not tested for may occur on release. I do appreciate that using the sanitizer to find bugs is a good idea. But as far as I know you have not actually discovered a real bug. "undefined behavior is never present in safe Rust <https://en.wikipedia.org/wiki/Rust_(programming_language)>" - undefined behaviour <https://en.wikipedia.org/wiki/Undefined_behavior>. Mike On Wed, Mar 1, 2023 at 12:32 PM Matthias Görgens ***@***.***> wrote: > @mcarrickscott <https://github.com/mcarrickscott> Rust has undefined > behaviour. Just much less than C. > > Just to be clear: I am not suggesting to compile the release version with > the sanitizer. I am suggesting to use the undefined behaviour sanitizer to > uncover bugs. Just like the address sanitizer already does. > > On any modern processor (including x86) compiling with > -fno-strict-overflow does not add overflow checks. > > Or which compiler flag are you talking about? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-milagro-crypto-c/pull/95#issuecomment-1449559513>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAU3ZDXGD7IBECLRTJBGAL3WZ4CTNANCNFSM6AAAAAATEDLYUI> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
