matthiasgoergens commented on PR #95: URL: https://github.com/apache/incubator-milagro-crypto-c/pull/95#issuecomment-1449633146
Yes, Rust is great, I like it, too. But let's leave that tangent aside for now? To be clear, I am suggesting two things. First, in addition to the address sanitizer we already use, we should also use undefined behaviour sanitizer. (And clang's memory sanitizer.) Second, I am suggesting that undefined behaviour by itself is a bug in cryptographic library that should be addressed. This PR implements the first point, and asks for help with the second. What, if anything, are you disagreeing with? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
