[ 
https://issues.apache.org/jira/browse/NIFI-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438544#comment-15438544
 ] 

ASF GitHub Bot commented on NIFI-2480:
--------------------------------------

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/956

    NIFI-2480: Fix for multibyte chars in breadcrumbs

    Removed $sanitize from breadcrumbs controller, as it escapes multibyte 
chars with numerical reference, and non-English names are not displayed in 
human readable way.
    Even without $sanitize, html tags can be escaped when Angular binds the 
value to text content.
    
    I confirmed that HTML tags are escaped without $sanitize as following 
screen-shots:
    
    
![image](https://cloud.githubusercontent.com/assets/1107620/17996071/745b2084-6ba1-11e6-9f4a-ae98fc6a8702.png)
    
    I hope this can be merged, and it doesn't have any negative impact by 
removing $sanitize.
    
    Thanks!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-2480

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/956.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #956
    
----
commit a5d643337b78e65829d03a69e4af11ef8bef4708
Author: Koji Kawamura <[email protected]>
Date:   2016-08-26T05:56:23Z

    NIFI-2480: Fix for multibyte chars in breadcrumbs
    
    Removed $sanitize from breadcrumbs controller, as it escapes multibyte
    chars with numerical reference. Even without $sanitize, html tags can be
    escaped when Angular binds the value to text content.

----


> None English characters are not displayed correctly in bread crumbs
> -------------------------------------------------------------------
>
>                 Key: NIFI-2480
>                 URL: https://issues.apache.org/jira/browse/NIFI-2480
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core UI
>    Affects Versions: 1.0.0
>            Reporter: Koji Kawamura
>            Priority: Minor
>         Attachments: screenshot-1.png
>
>
> When I set non English characters as a Processor Group Name, Operate pallet 
> and Process Group Node show it correctly. However, bread crumbs displays 
> decimal reference. 0.x UI was able to show those characters.
> Screenshot is attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to