hunyadi-dev commented on a change in pull request #835:
URL: https://github.com/apache/nifi-minifi-cpp/pull/835#discussion_r458087051
##########
File path: extensions/http-curl/tests/C2JstackTest.cpp
##########
@@ -29,7 +30,8 @@ class VerifyC2DescribeJstack : public VerifyC2Describe {
}
virtual void runAssertions() {
- assert(LogTestController::getInstance().contains("SchedulingAgent"));
+ using org::apache::nifi::minifi::utils::verifyLogLinePresenceInPollTime;
+
assert(verifyLogLinePresenceInPollTime(std::chrono::milliseconds(wait_time_),
"SchedulingAgent"));
Review comment:
We actually did. The implementation changed for
`libminifi/test/integration/IntegrationBase.h`. In addition, `contains`
actually used to wait a bit as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
