hunyadi-dev commented on a change in pull request #835:
URL: https://github.com/apache/nifi-minifi-cpp/pull/835#discussion_r458089850
##########
File path: extensions/http-curl/tests/C2UpdateTest.cpp
##########
@@ -174,15 +174,19 @@ int main(int argc, char **argv) {
controller->load();
controller->start();
- waitToVerifyProcessor();
+
+ const bool test_success =
verifyEventHappenedInPollTime(std::chrono::seconds(10), [] {
+ std::string logs = LogTestController::getInstance().log_output.str();
+ return logs.find("Starting to reload Flow Controller with flow control
name MiNiFi Flow, version") != std::string::npos;
+ });
Review comment:
I think the final version does just that. You probably reviewed an
earlier iteration, where this function did not exist yet, but I think I went
and replaced all similar occurences.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
