hunyadi-dev commented on a change in pull request #835: URL: https://github.com/apache/nifi-minifi-cpp/pull/835#discussion_r458821992
########## File path: libminifi/include/utils/IntegrationTestUtils.h ########## @@ -0,0 +1,64 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <utility> +#include <string> +#include <vector> + +#include "../../../libminifi/test/TestBase.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace utils { + +template <class Rep, class Period, typename Fun> +bool verifyEventHappenedInPollTime(const std::chrono::duration<Rep, Period>& wait_duration, Fun&& check) { + std::chrono::system_clock::time_point wait_end = std::chrono::system_clock::now() + wait_duration; + do { + if (std::forward<Fun>(check)()) { + return true; + } + std::this_thread::sleep_for(std::chrono::milliseconds(100)); + } while (std::chrono::system_clock::now() < wait_end); + return false; +} + +template <class Rep, class Period, typename ...String> +bool verifyLogLinePresenceInPollTime(const std::chrono::duration<Rep, Period>& wait_duration, String&&... patterns) { + // gcc before 4.9 does not support capturing parameter packs in lambdas: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=41933 + // Once we support gcc >= 4.9 only, this vector will no longer be necessary, we'll be able to iterate on the parameter pack directly. + std::vector<std::string> pattern_list{std::forward<String>(patterns)...}; Review comment: I prefer this name as it clearly indicates, that we are periodically polling for events and not just handling signals. Also, I am not completely convinced, but initializer lists would also copy the argument strings in order to construct a vector out of them and adding a workaround later is less convenient in that case. I don't think it is worth the effort to change the implementation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
