adamdebreceni commented on a change in pull request #897:
URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484279314
##########
File path: libminifi/include/utils/HTTPClient.h
##########
@@ -300,6 +319,9 @@ class BaseHTTPClient {
virtual void setUploadCallback(HTTPUploadCallback *callbackObj) {
}
+ virtual void setSeekFunction(HTTPUploadCallback *callbackObj) {
+ }
Review comment:
it seems like `HTTPClient` is the only class inheriting from it, and
noone directly instantiates a `BaseHTTPClient`, could we make these noop
virtual methods pure virtual?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
