lordgamez commented on a change in pull request #897:
URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484364547
##########
File path: libminifi/include/utils/ByteArrayCallback.h
##########
@@ -57,6 +57,7 @@ class ByteInputCallBack : public InputStreamCallback {
}
virtual void seek(size_t pos) {
+ ptr = &vec[pos];
Review comment:
Curl proxy authentication requires 2 steps (getting the available
authentication methods then authenticate with the chosen one) and after the
first step it needs a data rewind which requires implementing the seek
function. You are right, it broke the getBuffer that's what partly caused the
test failures, it is fixed in
[e0e31c5](https://github.com/apache/nifi-minifi-cpp/pull/897/commits/e0e31c5e96e0ad29c54ca09230a845588664b864)
##########
File path: extensions/http-curl/processors/InvokeHTTP.h
##########
@@ -155,8 +155,10 @@ class InvokeHTTP : public core::Processor {
bool use_chunked_encoding_{false};
// penalize on no retry
bool penalize_no_retry_{false};
- // disable peer verification ( makes susceptible for MITM attacks )
- bool disable_peer_verification_{false};
+ bool disable_peer_verification_{false}; // ( makes susceptible for MITM
attacks )
+ bool follow_redirects_{true};
Review comment:
Fixed in
[e0e31c5](https://github.com/apache/nifi-minifi-cpp/pull/897/commits/e0e31c5e96e0ad29c54ca09230a845588664b864)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
