arpadboda commented on a change in pull request #897:
URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484283890
##########
File path: extensions/http-curl/processors/InvokeHTTP.cpp
##########
@@ -246,6 +246,20 @@ void InvokeHTTP::onSchedule(const
std::shared_ptr<core::ProcessContext> &context
if (context->getProperty(DisablePeerVerification.getName(),
disablePeerVerification)) {
utils::StringUtils::StringToBool(disablePeerVerification,
disable_peer_verification_);
}
+
+ std::string proxy_value;
+ if (context->getProperty(ProxyHost.getName(), proxy_value) &&
!proxy_value.empty()) {
+ proxy_.host = proxy_value;
+ }
+ if (context->getProperty(ProxyPort.getName(), proxy_value) &&
!proxy_value.empty()) {
+ proxy_.port = std::stoi(proxy_value);
Review comment:
The other reason to remove if statements is updating the config: we
should null the members, otherwise proxy properties can't be removed without
restarting minifi.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
