hunyadi-dev opened a new pull request #940: URL: https://github.com/apache/nifi-minifi-cpp/pull/940
Notes: 1. This Pull request depends on having the librdkafka version updated (#924). 1. The testing performed so far was run manually only. by having a kafka broker running locally and executing the ConsumeKafkaTest test-cases. This is planned to be automatized in a separate PR by having both the broker and the tests run in a docker container. 1. Security protocols for kafka are not implemented yet, it will be added in yet another PR. 1. Polling in batches are not currently handled the same as how NiFi would, I have an open question for Edenhill about how the non-legacy C API is expected to be able to properly batch requests without committing back offsets inbetween poll calls. This is quite a sizeable PR, upon reviewing, I recommend first going through ConsumeKafkaTests.cpp and comparing the tests with the [requirements listed here](https://nifi.apache.org/docs/nifi-docs/components/nifi-docs/components/org.apache.nifi/nifi-kafka-2-0-nar/1.9.0/org.apache.nifi.processors.kafka.pubsub.ConsumeKafka_2_0/index.html). `Max Uncommitted Time` and `Communications Timeout` was replaced with `MaxPollTime` and `Session Timeout` options due to API differences. There is also a new property added on how to handle multiple headers of the same keys, called `DuplicateHeaderHandling`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
