hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r528647463
##########
File path: libminifi/src/utils/StringUtils.cpp
##########
@@ -35,7 +35,11 @@ std::string StringUtils::trim(std::string s) {
return trimRight(trimLeft(s));
}
-std::vector<std::string> StringUtils::split(const std::string &str, const
std::string &delimiter) {
Review comment:
Line 43 here could have caused bad memory access in case an empty
delimiter. This was a potential SPoF in the `ExpressionLanguage`'s
`allDelineatedValues`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
